Yes, in almost all cases, each player needs their own copy of the game to play together online on Xbox 360.
For standard retail games (Halo, Call of Duty, Gears of War, etc.), both players must own the game — either physically or digitally — to join each other's sessions via Xbox Live Gold.